This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Move wiki files to corefx and coreclr repos #1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Give a link to MSBuild 2013, since that's required for a VS2015 installation.
richlander
force-pushed
the
rich-docs-update
branch
from
bc0cfba
to
3b25e0d
Compare
|
|
||
| For work that involves adding new APIs we'd like the issue to contain what we call a *speclet*. The speclet should provide a rough sketch of how the APIs are intended to be used, with sample code that shows typical scenarios. The goal isn't to be complete but rather to illustrate the direction so that readers can judge whether the proposal is sound. Here is [a good example](https://github.com/dotnet/corefx/issues/271). | ||
|
|
||
|  |
There was a problem hiding this comment.
This is the only file in the img folder, move it to the existing images folder.
richlander
force-pushed
the
rich-docs-update
branch
from
4a4cfa9
to
550d51d
Compare
|
👍 Thanks, @richlander. |
| Building CoreFX on Linux | ||
| ======================== | ||
|
|
||
| CoreFx can be built on top of current [Mono CI builds](https://github.com/dotnet/corefx/wiki/Building-On-Unix#installing-mono-packages) or a direct [build/install of Mono](http://www.mono-project.com/docs/compiling-mono/). It builds using MSBuild and Roslyn and requires changes that have not yet made it to official released builds. |
There was a problem hiding this comment.
Does this wiki link need to point into something else instead?
|
A few minor comments, but otherwise LGTM. |
richlander
force-pushed
the
rich-docs-update
branch
2 times, most recently
from
18c39ac
to
5dae407
Compare
|
LGTM |
richlander
force-pushed
the
rich-docs-update
branch
4 times, most recently
from
017f0d1
to
8c9236d
Compare
|
I made a couple more changes for symmetry between the repos. The following files are now same-named (with different but analogous content) across both repos to make it look like there was a single approach across them. Novel idea, eh?
I will continue to rename files towards this end, should differences crop up. There was a small bit of different casing styles. I fixed those, too. |
|
I like it, seems much more consistent now 👍 |
|
@akoeplinger Fixed the CONTRIBUTING.md issue. Updated both links. Good catch. |
richlander
force-pushed
the
rich-docs-update
branch
from
8d045cf
to
9602459
Compare
richlander
force-pushed
the
rich-docs-update
branch
from
9602459
to
068c2c5
Compare
richlander
added a commit
that referenced
this pull request
Jun 3, 2015
Move wiki files to corefx and coreclr repos
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Move wiki files to corefx and coreclr repos Commit migrated from dotnet/corefx@5c6e421
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: dotnet/coreclr#1075. Some of the links in this PR are dependent on this CoreCLR PR being merged.
In reponse to issue #1781.
/cc @ellismg, @janvorli, @blackdwarf, @terrajobst, @akoeplinger