Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Enable interpreter build #11252

Merged
merged 2 commits into from
Apr 28, 2017
Merged

Conversation

parjong
Copy link

@parjong parjong commented Apr 27, 2017

#11188 allows users to enable interpreter feature via command-line, but build fails when this feature is enabled due to the following two reasons:

This commit fixes interpreter build error to properly enable interpreter feature with cmakeargs option.

@@ -233,5 +233,8 @@
#define FEATURE_STACK_SAMPLING
#endif // defined (ALLOW_SXS_JIT)

#if defined(USE_INTERPRETER)
#define FEATURE_INTERPRETER
#endif // USE_INTERPRETER
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if, instead of adding another name (USE_INTERPRETER), it would be better to add, here:

#if defined(CROSSGEN_COMPILE)
#if defined(FEATURE_INTERPRETER)
#undef FEATURE_INTERPRETER // No interpreter in crossgen builds
#endif
#endif

?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for comment! It works well. I updated PR as you suggested.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants