This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Do not devirtualize shared default interface methods #15979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The result of the devirtualization for a method on a generic type should be an instantiating stub, but this doesn't seem to work right. Fixing that is a perf issue (that can be triaged/punted - #15977). This commit is a correctness fix to avoid bad codegen for that case. Resolves #15591.
|
cc @AndyAyersMS |
jkotas
approved these changes
Jan 23, 2018
|
Change looks reasonable. Was expecting some kind of interaction. A few comments on the tests: I would recommend revising the default interface test project files so that jit optimization is always enabled, otherwise the tests will inherit optimization settings from the ambient build. That way these failures would have likely surfaced earlier in debug/check builds. You can add a second project file if you also want to run the tests with jit optimization disabled. Also, you should add the standard header boilerplate comments to the test sources. |
|
Thanks for the feedback Andy! I'll look into fixing the test headers/projects in a separate pull request. |
MichalStrehovsky
added a commit
to MichalStrehovsky/coreclr
that referenced
this pull request
Jan 24, 2018
* The diamondshape test should work now that dotnet#15979 and dotnet#15978 are merged. * Create debug and retail version of diamondshape and sharedgenerics tests so that we have retail coverage. These tests hit issues around devirtualization (that is only active when RyuJIT is optimizing).
MichalStrehovsky
added a commit
that referenced
this pull request
Jan 30, 2018
* The diamondshape test should work now that #15979 and #15978 are merged. * Create debug and retail version of diamondshape and sharedgenerics tests so that we have retail coverage. These tests hit issues around devirtualization (that is only active when RyuJIT is optimizing). * Add license headers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result of the devirtualization for a method on a generic type should be an instantiating stub, but this doesn't seem to work right.
Fixing that is a perf issue (that can be triaged/punted - #15977). This commit is a correctness fix to avoid bad codegen for that case.
Resolves #15591.