This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Rename conflicting definitions VER_MAJOR/MINORVERSION macros #17364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ericeil Noticed this while looking at impact of your PR. |
jkotas
force-pushed
the
ver
branch
2 times, most recently
from
a58d6bd
to
d960439
Compare
These macros are defined by Windows SDK. They were overload to mean CLR version that was causing interesting redefinition issues.
|
@dotnet-bot test Ubuntu arm Cross Checked Innerloop Build and Test |
|
@dotnet-bot test Windows_NT arm Cross Checked Innerloop Build and Test |
|
@dotnet-bot test Windows_NT arm64 Cross Checked Innerloop Build and Test |
|
@dotnet-bot test Ubuntu x64 Checked Innerloop Build and Test |
janvorli
approved these changes
Apr 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These macros are defined by Windows SDK. They were overload to mean CLR version that was causing interesting redefinition issues.