This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix xplat debugging perf problem. #19911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ARM build failing with: |
Issue #18705 Add threadId to DebuggerIPCEvent so we don't need to use the slow DAC functions (because of extra memory reads) to get it. Fixed CorDBIPC_BUFFER_SIZE on arm builds.
mikem8361
force-pushed
the
crossthread
branch
from
7125d78
to
5be347c
Compare
noahfalk
approved these changes
Sep 13, 2018
|
@dotnet-bot test please |
|
@dotnet-bot test Windows_NT arm Cross Debug Innerloop Build |
mikem8361
added a commit
to mikem8361/coreclr
that referenced
this pull request
Sep 19, 2018
Issue #18705 Add threadId to DebuggerIPCEvent so we don't need to use the slow DAC functions (because of extra memory reads) to get it. Fixed CorDBIPC_BUFFER_SIZE on arm builds.
mikem8361
added a commit
to mikem8361/coreclr
that referenced
this pull request
Sep 26, 2018
Issue #18705 Add threadId to DebuggerIPCEvent so we don't need to use the slow DAC functions (because of extra memory reads) to get it. Fixed CorDBIPC_BUFFER_SIZE on arm builds.
mikem8361
added a commit
to mikem8361/coreclr
that referenced
this pull request
Oct 2, 2018
Issue #18705 Add threadId to DebuggerIPCEvent so we don't need to use the slow DAC functions (because of extra memory reads) to get it. Fixed CorDBIPC_BUFFER_SIZE on arm builds.
danmoseley
pushed a commit
that referenced
this pull request
Oct 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #18705
Add threadId to DebuggerIPCEvent so we don't need to use the
slow DAC functions (because of extra memory reads) to get it.