Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Remove a use of gtGetOp in earlyprop. #8503

Merged
merged 1 commit into from
Dec 7, 2016
Merged

Remove a use of gtGetOp in earlyprop. #8503

merged 1 commit into from
Dec 7, 2016

Conversation

pgavlin
Copy link

@pgavlin pgavlin commented Dec 7, 2016

Instead, use GenTreeIndir::Addr, as some indirections are not simple
operators.

Fixes VSO 289704.

@pgavlin
Remove a use of gtGetOp in earlyprop.
95de3a0 
Instead, use `GenTreeIndir::Addr`, as some indirections are not simple
operators.

Fixes VSO 289704.
@pgavlin
Copy link
Author

pgavlin commented Dec 7, 2016

@JosephTremoulet @erozenfeld PTAL

JosephTremoulet
JosephTremoulet approved these changes Dec 7, 2016
View reviewed changes
Copy link

@JosephTremoulet JosephTremoulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So gtOp1 of a GenTreeUnOp isn't the same thing as gtOp.gtOp1 of a GenTree? Ok...

@pgavlin
Copy link
Author

pgavlin commented Dec 7, 2016

@JosephTremoulet: the problem is that AsOp asserts that the receiver is "simple", which is not true for all nodes that are considered indirections (i.e. DYN_BLK and STORE_DYN_BLK). Structurally, gtOp1 is the same. See #8486 for more discussion.

@pgavlin pgavlin merged commit f3895a3 into dotnet:master Dec 7, 2016
@pgavlin pgavlin deleted the VSO289704 branch December 7, 2016 18:17
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@pgavlin
Merge pull request dotnet/coreclr#8503 from pgavlin/VSO289704
27ea4ce 
Remove a use of `gtGetOp` in earlyprop.

Commit migrated from dotnet/coreclr@f3895a3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JosephTremoulet JosephTremoulet JosephTremoulet approved these changes

Assignees
No one assigned
Labels
area-CodeGen
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pgavlin @JosephTremoulet @karelz @dnfclas