This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Update CLI to 1.0.0-preview2-1-003182, BuildTools to 1.0.27-prerelease-01205-03 #8829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI errors look like they happened due to the buildtools upgrade. Looking into them. (The upgrade span is around 2 months.) |
|
LGTM, once the potential issues with the buildtools upgrade are addressed. |
dagood
commented
Jan 6, 2017
| <FinalOutputPath Condition="'$(FinalOutputPath)' == ''">$(BinDir)</FinalOutputPath> | ||
| </PropertyGroup> | ||
|
|
||
| <Import Condition="Exists('$(ToolsDir)BuildVersion.targets')" Project="$(ToolsDir)BuildVersion.targets" /> |
There was a problem hiding this comment.
BuildVersion.targets provides a value for BuildVersionFile, which is required by Versioning.targets.
To generate that default, I needed BaseIntermediateOutputPath from /dir.props, so I brought over the full Output paths property group and a single entry from Common properties.
|
@dotnet-bot test Ubuntu x64 Checked Build and Test (Known flakiness: https://github.com/dotnet/coreclr/issues/6574) |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…e-01205-03 (dotnet/coreclr#8829) * Update CLI to 1.0.0-preview2-1-003182, BuildTools to 1.0.27-prerelease-01205-03 * Add BuildVersion.targets and required properties to test directory's dir.props Commit migrated from dotnet/coreclr@6784aa6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See dotnet/corefx#14933