Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Process perf tests #20414

Closed
DrewScoggins opened this issue Mar 3, 2017 · 3 comments
Closed

Disable Process perf tests #20414

DrewScoggins opened this issue Mar 3, 2017 · 3 comments
Assignees
@DrewScoggins
Labels
area-System.Diagnostics.Process tenet-performance Performance related issue test-bug Problem in test source code (most likely)
Milestone
3.0

Comments

@DrewScoggins
Copy link
Member

With the new performance harness tooling that we are adding we generate too many events during the Process performance tests. This causes to drop events and fail to upload results. We should fix these tests, but I would like to go ahead and start getting results for the rest of the tests so I am going to disable these until we do the work to fix them.
@DrewScoggins DrewScoggins self-assigned this Mar 3, 2017
DrewScoggins referenced this issue in DrewScoggins/corefx Mar 3, 2017
@DrewScoggins
Disable process perf tests
8d8137c 
Tracking this with issue
[16653](https://github.com/dotnet/corefx/issues/16653). I am disabling
these tests for now so that we can start to get results for the rest of
the tests, as these failures are blocking upload.
DrewScoggins referenced this issue in DrewScoggins/corefx Mar 3, 2017
@DrewScoggins
Disable process perf tests
e07cdeb 
Tracking this with issue
[16653](https://github.com/dotnet/corefx/issues/16653). I am disabling
these tests for now so that we can start to get results for the rest of
the tests, as these failures are blocking upload.
DrewScoggins referenced this issue in DrewScoggins/corefx Mar 3, 2017
@DrewScoggins
Disable process perf tests
7655033 
Tracking this with issue
[16653](https://github.com/dotnet/corefx/issues/16653). I am disabling
these tests for now so that we can start to get results for the rest of
the tests, as these failures are blocking upload.
DrewScoggins referenced this issue in DrewScoggins/corefx Mar 6, 2017
@DrewScoggins
Disable process perf tests
4316a94 
Tracking this with issue
[16653](https://github.com/dotnet/corefx/issues/16653). I am disabling
these tests for now so that we can start to get results for the rest of
the tests, as these failures are blocking upload.
@karelz
Copy link
Member

karelz commented Mar 17, 2017

This is not necessary for 2.0, pushing to Future.

DrewScoggins referenced this issue in DrewScoggins/corefx Mar 21, 2017
@DrewScoggins
Disable process perf tests
7ec2bf3 
Tracking this with issue
[16653](https://github.com/dotnet/corefx/issues/16653). I am disabling
these tests for now so that we can start to get results for the rest of
the tests, as these failures are blocking upload.
@stephentoub
Copy link
Member

@adamsitnik, is this still an issue? Can we close this?

@adamsitnik
Copy link
Member

@stephentoub yes, I have redesigned and re-enabled those tests in dotnet/performance#111

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 3.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DrewScoggins DrewScoggins

Labels
area-System.Diagnostics.Process tenet-performance Performance related issue test-bug Problem in test source code (most likely)
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
5 participants
@stephentoub @karelz @adamsitnik @msftgits @DrewScoggins