-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NamedPipeServerStream: Provide support for WRITE_DAC #23554
Comments
@ianhays we removed the ctors from AnonymousPipeServerStream as well as NamedPipeClientStream and NamedPipeServerStream. But AnonymousPipeServerStream does not have a ctor that takes PipeOptions. I notice AnonymousPipeClientStream does not take PipeSecurity on desktop, only the server, so I'm not sure how those semantics work. |
@jaredpar do you need this for code that runs on 2.0, ie., do we need to service for it? cc @weshaggard its intersting this is the first case I've seen where removing members for net standard broke functionality |
Jared's in-office suggestion was to add a new ctor with a bool to indicate that Since we already have the value on We just can't let a new-bool ctor and a PipeAccessRights ctor ever touch. |
What about moving |
Ugh, that constructor also needs PipeSecurity. I guess in theory we could move that down also, potentially using reflection to not pull all of S.IO.Pipes.AccessControl with it. |
I hate to make a .NET Core specific API, as it basically only helps Jared. |
My problem with the constructor (beyond it being little more than a limited version of a netfx constructor) is that it's highly visible despite it being unneeded for most scenarios.
That's true, but either way we're going to be adding redundant API by a different name. IMO we should either bury it as deep as we can or revisit whether it's something we really need to expose. |
This is required for 2.1 for persistent Roslyn and MSBuild processes. |
Update, Roslyn/MSBuild will use https://app.zenhub.com/workspace/o/dotnet/corefx/issues/25427 |
Is there a way this could be fixed? The whole PipeSecurity package is useless without this. |
@danmosemsft, is anyone working on this for 3.0? |
@carlossanlop Was this taken care of in our ACL work that you did? |
When creating a
NamedPipeServerStream
on Windows,WRITE_DAC
onCreateNamedPipe
will always be unset. On netfx we had a constructor that took aPipeSecurity
object with ACL info but we had to take that out for netcore/netstandard.We should add a new entry on netcoreapp to the
PipeOptions
enum to set WRITE_DAC:cc: @bartonjs @stephentoub @jaredpar
The text was updated successfully, but these errors were encountered: