Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Threading.Tasks.Extensions package needs _._ placeholders for Xamarin platforms #26117

Closed
akoeplinger opened this issue May 8, 2018 · 15 comments
Labels
Milestone

Comments

@akoeplinger
Copy link
Member

We're adding a facade for System.Threading.Tasks.Extensions.dll inbox so we'd like to add the placeholders for the usual Xamarin platforms to the package.

/cc @weshaggard

@weshaggard
Copy link
Member

@akoeplinger we are in escrow mode for .NET Core 2.1 when do you guys need this?

@akoeplinger
Copy link
Member Author

I don't think we're in a rush to get this. We found out about it because Roslyn is adding a dependency on this package.

/cc @marek-safar

@marek-safar
Copy link
Contributor

@weshaggard 2.2 milestone seems to be too far away (months right?). Could we get it fixed sooner as customers seem to start hitting this?

@weshaggard
Copy link
Member

@tarekgh it looks like you own this package is it this something you can do and drive?

@tarekgh
Copy link
Member

tarekgh commented May 21, 2018

@weshaggard could you please advise how we can do that? I am not familiar with that but I can follow up if I have some guidance.

@tarekgh
Copy link
Member

tarekgh commented May 21, 2018

I talked offline to @joperezr and he described how I can do that. I'll try to submit a PR for that.

@weshaggard
Copy link
Member

It will be a PR similar to dotnet/corefx@6813af0#diff-f464c49eb9b66f6721df0d4e8ad4c14f

@tarekgh
Copy link
Member

tarekgh commented May 22, 2018

@joperezr
Copy link
Member

re-opening to track port to release branch.

@joperezr joperezr reopened this May 22, 2018
@joperezr
Copy link
Member

@weshaggard looks like @marek-safar needs this to ship before 2.2, any chance we would consider this for 2.1 or 2.1 servicing?

@danmoseley
Copy link
Member

It sounded like there were other packages with this issue - system.Buffers? If so I'd like to bring them all together.

@joperezr
Copy link
Member

Sorry, I didn't see that we have another issue that is already tracking the port of this on 2.1 along with other libraries (like SYstem.Buffers) so I'll close this one as a dupe to dotnet/corefx#29828

@marek-safar
Copy link
Contributor

marek-safar commented May 23, 2018

These were filled as separate issues because they are addressing separate problems. Hence this is not dupe of dotnet/corefx#29828 because the fixes need to land at different time with the current way of shipping the core nugets.

This one should have 2.1.x milestone

@weshaggard
Copy link
Member

Reopening to track this particular issue for 2.1 servicing.

@weshaggard weshaggard reopened this May 23, 2018
@tarekgh
Copy link
Member

tarekgh commented Jun 1, 2018

Fixed by dotnet/corefx#29922 in release/2.1 branch. Will ship in 2.1.1 release

@tarekgh tarekgh closed this as completed Jun 1, 2018
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.1.x milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

7 participants