Copyright and authorship missing on a few source code files #85

Closed
maxbrito opened this Issue Nov 14, 2014 · 1 comment

Comments

Projects
None yet
4 participants
@maxbrito

Hello,

I've noted that some files likely need the due header with copyright and license statement. Example:
https://github.com/dotnet/corefx/blob/master/src/System.Reflection.Metadata/tests/Resources/NetModule/ModuleCS01.cs

Likely missing a header as:

// Copyright (c) Microsoft. All rights reserved.
// Licensed under the MIT license. See LICENSE file in the project root for full license information.

The header helps with the provenance task when these files get separated from the original development. From what I can tell, these aren't auto-generated files, just normal source code.

Affected files:

./src/System.Reflection.Metadata/tests/Resources/NetModule/ModuleCS00.cs
./src/System.Reflection.Metadata/tests/Resources/NetModule/ModuleCS01.cs
./src/System.Reflection.Metadata/tests/Resources/NetModule/ModuleVB01.vb
./src/System.Reflection.Metadata/tests/Resources/Namespace/NamespaceForwardedCS.cs
./src/System.Reflection.Metadata/tests/Resources/Namespace/NamespaceTests.cs
./src/System.Reflection.Metadata/tests/Resources/Misc/CPPClassLibrary2.h
./src/System.Reflection.Metadata/tests/Resources/Misc/Members.cs
./src/System.Reflection.Metadata/tests/Resources/Interop/Interop.Mock01.cs
./src/System.Reflection.Metadata/tests/Resources/Interop/Interop.Mock01.Impl.cs
./src/System.Collections.Immutable/tests/PinnedImmutableArrayTests.cs

Not sure if these files count as authored code:

./src/System.Reflection.Metadata/tests/Resources/Interop/IndexerWithByRefParam.il
./src/System.Numerics.Vectors/tests/GenericVectorTests.tt
./src/System.Numerics.Vectors/src/System/Numerics/ConstantHelper.tt
./src/System.Numerics.Vectors/src/System/Numerics/Register.tt
./src/System.Numerics.Vectors/src/System/Numerics/Vector.tt

With kind regards,
Nuno Brito

@nguerrera

This comment has been minimized.

Show comment
Hide comment
@nguerrera

nguerrera Nov 15, 2014

Member

This is fixed.

Member

nguerrera commented Nov 15, 2014

This is fixed.

@nguerrera nguerrera closed this Nov 15, 2014

@karelz karelz modified the milestone: 1.0.0-rtm Dec 3, 2016

Olafski pushed a commit to Olafski/corefx that referenced this issue Jun 15, 2017

filipnavara pushed a commit to filipnavara/corefx that referenced this issue Jul 18, 2018

Added ability to work with 'legacy' System.Configuration in Mono (#85)
All that really does is read machine.config from disk.

Adjusted configuration so the ImplicitMachineConfigHost is used along
with the original ConfigSystem. Added a check in IMCH to look for
and load an embedded machine.config if found.

Not all hostParams have the first array element as the filemap (e.g.
System.Web configuration) so use "as" instead of an explicit cast.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment