Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright and authorship missing on a few source code files #13877

Closed
maxbrito opened this issue Nov 14, 2014 · 1 comment
Closed

Copyright and authorship missing on a few source code files #13877

maxbrito opened this issue Nov 14, 2014 · 1 comment
Assignees
Milestone

Comments

@maxbrito
Copy link

Hello,

I've noted that some files likely need the due header with copyright and license statement. Example:
https://github.com/dotnet/corefx/blob/master/src/System.Reflection.Metadata/tests/Resources/NetModule/ModuleCS01.cs

Likely missing a header as:

// Copyright (c) Microsoft. All rights reserved.
// Licensed under the MIT license. See LICENSE file in the project root for full license information.

The header helps with the provenance task when these files get separated from the original development. From what I can tell, these aren't auto-generated files, just normal source code.

Affected files:

./src/System.Reflection.Metadata/tests/Resources/NetModule/ModuleCS00.cs
./src/System.Reflection.Metadata/tests/Resources/NetModule/ModuleCS01.cs
./src/System.Reflection.Metadata/tests/Resources/NetModule/ModuleVB01.vb
./src/System.Reflection.Metadata/tests/Resources/Namespace/NamespaceForwardedCS.cs
./src/System.Reflection.Metadata/tests/Resources/Namespace/NamespaceTests.cs
./src/System.Reflection.Metadata/tests/Resources/Misc/CPPClassLibrary2.h
./src/System.Reflection.Metadata/tests/Resources/Misc/Members.cs
./src/System.Reflection.Metadata/tests/Resources/Interop/Interop.Mock01.cs
./src/System.Reflection.Metadata/tests/Resources/Interop/Interop.Mock01.Impl.cs
./src/System.Collections.Immutable/tests/PinnedImmutableArrayTests.cs

Not sure if these files count as authored code:

./src/System.Reflection.Metadata/tests/Resources/Interop/IndexerWithByRefParam.il
./src/System.Numerics.Vectors/tests/GenericVectorTests.tt
./src/System.Numerics.Vectors/src/System/Numerics/ConstantHelper.tt
./src/System.Numerics.Vectors/src/System/Numerics/Register.tt
./src/System.Numerics.Vectors/src/System/Numerics/Vector.tt

With kind regards,
Nuno Brito

@nguerrera
Copy link
Contributor

This is fixed.

Olafski referenced this issue in Olafski/corefx Jun 15, 2017
filipnavara referenced this issue in filipnavara/corefx Jul 18, 2018
All that really does is read machine.config from disk.

Adjusted configuration so the ImplicitMachineConfigHost is used along
with the original ConfigSystem. Added a check in IMCH to look for
and load an embedded machine.config if found.

Not all hostParams have the first array element as the filemap (e.g.
System.Web configuration) so use "as" instead of an explicit cast.
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 1.0.0-rtm milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants