Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Replace SkipBytes and SeekOffset with Offset setter #12375

Merged
merged 1 commit into from Oct 5, 2016

Conversation

tmat
Copy link
Member

@tmat tmat commented Oct 5, 2016

No description provided.

@tmat
Copy link
Member Author

tmat commented Oct 5, 2016

@nguerrera

Assert.Throws<BadImageFormatException>(() => block.GetMemoryBlockAt(-int.MaxValue, int.MaxValue));
Assert.Throws<BadImageFormatException>(() => block.GetMemoryBlockAt(int.MaxValue, -int.MaxValue));
Assert.Throws<BadImageFormatException>(() => block.GetMemoryBlockAt(int.MaxValue, int.MaxValue));
Assert.Throws<BadImageFormatException>(() => block.GetMemoryBlockAt(block. Length, -1));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra space.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@nguerrera
Copy link
Contributor

LGTM

@tmat
Copy link
Member Author

tmat commented Oct 5, 2016

test Innerloop CentOS7.1 Release Build and Test please

@tmat tmat merged commit ae0e558 into dotnet:master Oct 5, 2016
@tmat tmat deleted the BlobReaderOffset branch October 5, 2016 19:12
tmat added a commit to tmat/corefx that referenced this pull request Oct 7, 2016
@karelz karelz modified the milestone: 1.2.0 Dec 3, 2016
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants