This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Remove unnecessary GetTypeInfo calls from Microsoft.VisualBasic #16413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just one left that uses GetDeclaredMethods method. Contributes to #16305 Also have GetTypeCode extension call into Type.GetTypeCode as that is now available.
JonHanna
force-pushed
the
gettypeinfo_visualbasic
branch
from
3a55cd4
to
ed845bf
Compare
JonHanna
commented
Feb 23, 2017
| @@ -223,6 +223,7 @@ Namespace Microsoft.VisualBasic.CompilerServices | |||
| Case TypeCode.Char : Return GetType(Char) | |||
| Case TypeCode.String : Return GetType(String) | |||
| Case TypeCode.Object : Return GetType(Object) | |||
| Case TypeCode.DBNull : Return GetType(DBNull) | |||
There was a problem hiding this comment.
The GetTypeCode extension hadn't been updated when DBNull was introduced to deal with the possibility of such values, which was a bug. Going through Type.GetTypeCode means that is now fixed, but this possible result has to be considered here. This seems to be the only place where the new possibility of TypeCode.DBNull has an impact.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…albasic Remove unnecessary GetTypeInfo calls from Microsoft.VisualBasic Commit migrated from dotnet/corefx@bd9e77c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just one left that uses
GetDeclaredMethodsmethod.Contributes to #16305
Also have
GetTypeCodeextension call intoType.GetTypeCodeas that is now available.