This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Clean up dead code for System.Collections* #28840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
Apr 5, 2018
| /// </summary> | ||
| internal int Count | ||
| { | ||
| get { return _count; } |
There was a problem hiding this comment.
Is the _count field used anywhere else? Should it be deleted too?
jkotas
reviewed
Apr 5, 2018
| @@ -17,10 +17,6 @@ internal CompatibleComparer(IHashCodeProvider hashCodeProvider, IComparer compar | |||
| _comparer = comparer; | |||
| } | |||
|
|
|||
| internal IHashCodeProvider HashCodeProvider => _hcp; | |||
There was a problem hiding this comment.
I think splitting the file into two just because of these two trivial properties is not an improvement. I would keep it as it is.
There was a problem hiding this comment.
This was suggested to me, but I agree with you. Will fix.
jkotas
reviewed
Apr 6, 2018
| /// <summary> | ||
| /// Initializes a new instance of the <see cref="ImmutableDictionary{TKey, TValue}.MutationInput"/> struct. | ||
| /// </summary> | ||
| /// <param name="root">The root.</param> | ||
| /// <param name="comparers">The comparers.</param> | ||
| /// <param name="count">The current number of elements in the collection.</param> | ||
| /// |
There was a problem hiding this comment.
Nit: Delete this empty comment line.
stephentoub
approved these changes
Apr 6, 2018
danmoseley
added
the
* NO MERGE *
|
Marking no-merge to hold this for a week or so until master = 2.2 |
jkotas
approved these changes
Apr 17, 2018
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Commit migrated from dotnet/corefx@d7396b2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17905