This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Configuration tests #29896
Merged
Configuration tests #29896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I get some feedback on if the exception tests are overly specific/pedantic. It felt weird to create a test class for each, but I wanted to try to keep it organized. Not sure if it was the correct move |
Jlalond
force-pushed
the
configuration-tests
branch
from
5757ffc
to
a96f911
Compare
JeremyKuhne
approved these changes
May 24, 2018
| var collection = new SettingElementCollection(); | ||
| collection.Add(settingElement); | ||
| var retrievedElement = collection.Get("TestElementName"); | ||
| Assert.Equal(settingElement, retrievedElement); |
There was a problem hiding this comment.
Assert.Same to see that we get the same object instance back.
|
@JeremyKuhne just looked at the debug build, can't figure out why it's failing. Is there anything I need to do? |
|
@dotnet-bot test Windows x64 Debug Build |
@Jlalond probably nothing- I kicked the debug one again to be sure (history is gone). I'll merge this in once we get results. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Added some configuration unit tests * Initial Unit Test Changes * Got ConfigurationValidatorBase to 100% coverage * Stuck on AppSettingsReaderTests, pushing what I have * Changed my exception tests, they looked ugly * Changes from equal to same for setting element collection tests Commit migrated from dotnet/corefx@e623478
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15554 Finished a few tests, stuck on App Setting Reader which will be my next target. But figured I'd merge up what I've been working on in the meantime @JeremyKuhne