This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Ensure that the existing Vector2/Vector3/Vector4 intrinsic methods are marked as such. #34167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC. @CarolEidt, @fiigii |
tannergooding
commented
Dec 19, 2018
| @@ -209,7 +211,6 @@ public static Vector2 SquareRoot(Vector2 value) | |||
| /// <param name="left">The scalar value.</param> | |||
| /// <param name="right">The source vector.</param> | |||
| /// <returns>The scaled vector.</returns> | |||
| [Intrinsic] | |||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | |||
| public static Vector2 operator *(float left, Vector2 right) | |||
There was a problem hiding this comment.
The runtime only matches against TYP_STRUCT, TYP_STRUCT: https://github.com/dotnet/coreclr/blob/master/src/jit/simdintrinsiclist.h#L91
There was a problem hiding this comment.
Will revert the removal of this one, it might be handled by .NET Native as per dotnet/coreclr#21601 (comment)
There was a problem hiding this comment.
it might be handled by .NET Native
ARM seems to have instructions can directly support this form, so you may need to care about that.
…e marked as such.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…e marked as such. (dotnet/corefx#34167) Commit migrated from dotnet/corefx@ecb9b49
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the CoreFX side to: dotnet/coreclr#21601