This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Avoid unnecessary Span to ReadOnlySpan casts #34646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartonjs
approved these changes
Jan 17, 2019
In a bunch of places we're creating a Span only to then cast it (generally implicitly) to a ReadOnlySpan. While the JIT is generally able to do the RightThing(tm), we can avoid the unnecessary IL and pressure on the JIT by just creating a ReadOnlySpan to begin with.
stephentoub
force-pushed
the
spancasts
branch
from
de21a1f
to
1f7c11d
Compare
ahsonkhan
approved these changes
Jan 17, 2019
JRahnama
pushed a commit
to JRahnama/SqlClient
that referenced
this pull request
Sep 5, 2019
…nlySpan casts Port GitHub PR 34646: Avoid unnecessary Span to ReadOnlySpan casts dotnet/corefx#34646
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
In a bunch of places we're creating a Span only to then cast it (generally implicitly) to a ReadOnlySpan. While the JIT is generally able to do the RightThing(tm), we can avoid the unnecessary IL and pressure on the JIT by just creating a ReadOnlySpan to begin with. Commit migrated from dotnet/corefx@ab92553
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a bunch of places we're creating a Span only to then cast it (generally implicitly) to a ReadOnlySpan. While the JIT is generally able to do the RightThing(tm), we can avoid the unnecessary IL and pressure on the JIT by just creating a ReadOnlySpan to begin with.
Also cleaned up a few other minor span-related things as I was auditing, e.g. new Span(…).Slice(…) vs .AsSpan(…).
cc: @jkotas