This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Index and Ranges Changes #35003
Closed
Index and Ranges Changes #35003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarekgh
added
the
* NO MERGE *
ahsonkhan
reviewed
Feb 3, 2019
| public static System.Span<T> AsSpan<T>(this T[] array) { throw null; } | ||
| public static System.Span<T> AsSpan<T>(this T[] array, int start) { throw null; } | ||
| public static System.Span<T> AsSpan<T>(this T[] array, int start, int length) { throw null; } | ||
| public static Span<T> AsSpan<T>(this T[] array, Index startIndex) { throw null; } |
There was a problem hiding this comment.
If we are adding Index/Range overloads to AsSpan for array/segment, why not add it for string as well?
public static System.ReadOnlySpan<char> AsSpan(this string text, int start, int length) { throw null; }There was a problem hiding this comment.
This is a good question, I don't think this was discussed and I don't see a strong reason why we shouldn't have it. but in general it is easy to achieve the same with the current APIs String.AsSpan().Slice(Index/Range)
@terrajobst what you think about this one?
|
Cherry-picked into #35207 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on dotnet/coreclr#22331