This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Update dependencies from dotnet/coreclr #35207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
|
I am seeing the following errors but it is not clear to me why this is happening if we are getting the coreclr package that have the changes. I'll take a look |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
|
@stephentoub I think the failure we are seeing here is because the C# compiler using Index.FromEnd which used to return boolean in preview 1 and we have renamed this property to IsFromEnd and now using FromEnd as factory method to create an index object. Did we get any compiler update recently in corefx? The only way I guess to have this work is to comment the tests causing such failures. CC @agocke |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
|
We updated to Preview 2.
We don't need tests in corefx using the language syntax. If we have those, we can just delete them and make sure we have tests directly against the exposed surface area. |
|
We are not using new syntax at all. My understanding is in preview 1, the compiler was doing some hack to support string indexers without updating string class at all in the libraries. I am going to comment the tests causing these failures for now. basically anyone using string class with the Index indexer is broken and this is what the test was using. I think the string class with Range indexer would be broken too because of the removal of Range.Create. |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
|
I am seeing different failures in Utf8Formatter. Is this related to your changes? |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
|
@tarekgh, yes. I'll push up a commit deleting the tests (they are no longer valid in any way). There will be a separate PR adding new tests covering the new functionality. |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
…0208.73 This change updates the following dependencies - Microsoft.NET.Sdk.IL - 3.0.0-preview-27408-73 - Microsoft.NETCore.ILAsm - 3.0.0-preview-27408-73 - Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview-27408-73
…0209.72 This change updates the following dependencies - Microsoft.NET.Sdk.IL - 3.0.0-preview-27409-72 - Microsoft.NETCore.ILAsm - 3.0.0-preview-27409-72 - Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview-27409-72
…0210.72 This change updates the following dependencies - Microsoft.NET.Sdk.IL - 3.0.0-preview-27410-72 - Microsoft.NETCore.ILAsm - 3.0.0-preview-27410-72 - Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview-27410-72
stephentoub
force-pushed
the
darc-master-be4ecac4-471a-4e11-961e-78e7628e8c2c
branch
2 times, most recently
from
1ff0754
to
188fd6f
Compare
|
|
@bartonjs looks there is an assertion fired from the test |
|
stephentoub
force-pushed
the
darc-master-be4ecac4-471a-4e11-961e-78e7628e8c2c
branch
from
188fd6f
to
45b49ee
Compare
stephentoub
deleted the
darc-master-be4ecac4-471a-4e11-961e-78e7628e8c2c
branch
baulig
pushed a commit
to mono/corefx
that referenced
this pull request
Feb 12, 2019
…-4e11-961e-78e7628e8c2c Update dependencies from dotnet/coreclr (cherry picked from commit 0998699)
marek-safar
pushed a commit
to mono/corefx
that referenced
this pull request
Feb 12, 2019
…-4e11-961e-78e7628e8c2c Update dependencies from dotnet/coreclr (cherry picked from commit 0998699)
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…c4-471a-4e11-961e-78e7628e8c2c Update dependencies from dotnet/coreclr Commit migrated from dotnet/corefx@0998699
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
Updates from https://github.com/dotnet/coreclr
Updates from https://github.com/dotnet/coreclr
Updates from https://github.com/dotnet/coreclr