This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Thread principal unauthenticated #35112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
Feb 5, 2019
ViktorHofer
force-pushed
the
ThreadPrincipalUnauthenticated
branch
2 times, most recently
from
8ca2e65
to
b70ef22
Compare
ViktorHofer
force-pushed
the
ThreadPrincipalUnauthenticated
branch
from
b70ef22
to
7dc60fc
Compare
jkotas
reviewed
Feb 5, 2019
| Volatile.Write(ref s_getUnauthenticatedPrincipal, (Func<IPrincipal>)Delegate.CreateDelegate(typeof(Func<IPrincipal>), type, "GetDefaultInstance")); | ||
| // Don't throw PNSE if null like for WindowsPrincipal as UnauthenticatedPrincipal should | ||
| // be available on all platforms. | ||
| Volatile.Write(ref s_getUnauthenticatedPrincipal, |
There was a problem hiding this comment.
You should also delete ignoreCase: false, throwOnBindFailure: false and keep it as it used to be so that it throws exception when things go wrong.
stephentoub
approved these changes
Feb 6, 2019
ViktorHofer
force-pushed
the
ThreadPrincipalUnauthenticated
branch
from
0db8a55
to
2a9c5ff
Compare
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Remove bind error for thread principal * Disable threadpool test for uapaot * Disable MailMessage reflection test on uapaot * Disable ValueTask reflection tests on uapaot * Guard System.TestEnvironment against ILC * Revert AppDomain UnauthenticatedPrincipal change Commit migrated from dotnet/corefx@0424e9d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing an oversight that results in an exception on uapaot in AppDomain: #30765 (comment). I did not add the PNSE as I don't think it is needed?
Disabling a reflection blocked test and a thread pool test where a condition for uapaot is missing.
cc @danmosemsft @jkotas @Anipik