-
Notifications
You must be signed in to change notification settings - Fork 4.9k
[release/3.1] Switch to using 3.1100 SDK to build 3.1 #42757
Conversation
Required for upstack components, so this is for consistency.
@Anipik @ericstj @wtgodbe A ton of errors upgrading the sdk here. What do I need to do?
|
Taking a look, @safern @joperezr @ViktorHofer may also know |
These errors are in Lines 28 to 37 in b7c9ada
harvestPackages.props
|
That's not the problem, this should be coming from netcoreapp.depproj. These all target netcoreapp3.0: did the 3.1 SDK drop support for targeting netcoreapp3.0? @ViktorHofer was facing something similar in dotnet/runtime repo. |
A quick check of targeting nca3.0 in a simple console app worked for me. |
I found the problem but am currently pulled away from my machine. Will get back to it shortly. |
This should be fixed. FYI @joperezr I removed the condition you added in 9fe02e8 since we don't seem to need it and it was causing copy to be skipped in this case. @ViktorHofer I believe this addresses the comment I made here: dotnet/runtime#445 (comment) and likely the root cause of dotnet/runtime#121 |
Looks like we still need that condition, I will see how to make it work in both cases. |
1217bc3
to
623cfe7
Compare
@mmitche should be good. Merge at your liesure. (not sure the state of the branches ATM) |
Required for upstack components, so this is for consistency.