This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[release/2.1] Suppress the GrayListedLeaf error code on macOS X509Chain #42876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartonjs
added
area-System.Security
Servicing-consider
stephentoub
approved these changes
Feb 27, 2020
|
If memory serves, we've now had several of these servicing needs due to new error codes popping up. Should we revisit the decision to opt-in new codes on demand? |
My gut says we have to maintain a defensive posture here. But I opened dotnet/runtime#32941 to track the notion (with a hopeful "maybe there's functionality added to the OS between our old minimum and our new minimum version"). |
leecow
added
Servicing-approved
Anipik
approved these changes
Mar 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of dotnet/runtime#32895.
Description
Recent change to macOS has caused a new error code to appear during X509Chain building. Since this error code has been identified as not having impact on the .NET X509Chain class, ignore it.
Customer Impact
Without this fix, customers who upgrade their macOS version and build X509Chains against certificates/certificate-authorities which result in the GrayListedLeaf code will get a
CryptographicExceptiondue to the unmapped error.Regression?
No, reaction to OS update.
Packaging reviewed?
Required shim library, no packaging impact.
Risk
Low, covered by unit tests (which originally discovered the issue).