Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

[release/3.1-blazor] Fix Http.Json serialization performance by using static options (#35040) #42906

Merged
merged 1 commit into from
Apr 17, 2020
Merged

[release/3.1-blazor] Fix Http.Json serialization performance by using static options (#35040) #42906

merged 1 commit into from
Apr 17, 2020

Conversation

jozkee
Copy link
Member

@jozkee jozkee commented Apr 17, 2020

@jozkee jozkee requested a review from joperezr April 17, 2020 03:44
@joperezr
Copy link
Member

I just requeued the failed builds as they were just test failures on areas other than the ones you are changing here.

joperezr
joperezr approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM since they have already been approved in dotnet/runtime PR and nothing special is required for this blazor branch.

@ericstj
Copy link
Member

ericstj commented Apr 17, 2020

The OSX failure is #42875

We're missing @bartonjs's fix in this feature branch. We can ignore for now. We should merge release/3.1 into this branch.

@ericstj ericstj merged commit 935c865 into dotnet:release/3.1-blazor Apr 17, 2020
@jozkee jozkee deleted the 3.1/httpjson_perf branch April 17, 2020 23:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joperezr joperezr joperezr approved these changes

Assignees
No one assigned
Labels
area-System.Net.Http
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jozkee @joperezr @ericstj