Build the platforms package for shipping

[Anipik]

This #42928 change was mistakenly merged preemptively before the branch was open.
It lacked the packaging stuff, so just adding that

[safern]

Do we want to produce a stable package in the next build? Why are we changing this?

[Anipik]

yes we want a new stable version of the package in july/next release.

[safern]

But that should be driven by the property that we set to produce stable packages which will update the index.json file automatically as part of the build, right?

[Anipik]

no we dont have that for 3.1, i am the one that generally does it. Sometimes it gets missed and then done after the release

[wtgodbe]

This is consistent with how we've been doing it in 3.1: https://github.com/Anipik/corefx/commit/bbcc0a83f548afb76bbde6226bb4a5ae06a980ab#diff-cb73a137838f73872d476fa5146bfede

[safern]

I think you're miss-understanding me. We update it once we've shipped the stable packages and prepare for the next release, but in order to produce stable packages we run this target:

corefx/src/packages.builds

Lines 50 to 52 in 344805d

	<Target Name="UpdatePackageIndexWithStableVersions"
	BeforeTargets="BuildAllProjects"
	Condition="'$(DotNetFinalVersionKind)' == 'release'">

When DotNetFinalVersionKind is release. That target will get the packages we're building, will update the packageIndex.json in the build machine before building the packages and will produce stable packages.

Then, once we ship those to NuGet, you go and check-in those changes.

However, doing it here seems wrong, cause if we do a build were DotNetFinalVersionKind != release we will produce non-stable packages for all built packages of this release, and stable package for the platforms package.

Do you see what I'm saying?

[safern]

This is consistent with how we've been doing it in 3.1

Hmm then how do we produce non-stable servicing releases? That is the point of the target I pointed above.

[Anipik]

we no longer produces non-stable servicing release

[safern]

Ah ok, that is what was confusing me.

[Anipik]

I think we should be good either way

[wtgodbe]

Test failure unrelated