Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Move MethodSemanticsAttributes back to System.Reflection namespace #5995

Merged
merged 2 commits into from Feb 10, 2016
Merged

Move MethodSemanticsAttributes back to System.Reflection namespace #5995

merged 2 commits into from Feb 10, 2016

Conversation

tmat
Copy link
Member

@tmat tmat commented Feb 10, 2016

S.R.M.dll already shipped with public enums in System.Reflection namespace:

MethodImportAttributes
ManifestResourceAttributes
AssemblyHashAlgorithm
DeclarativeSecurityAction
AssemblyFlags

So adding MethodSemanticsAttributes keeps it consistent.

@tmat
Copy link
Member Author

tmat commented Feb 10, 2016

@nguerrera

@nguerrera
Copy link
Contributor

👍

@tmat
Copy link
Member Author

tmat commented Feb 10, 2016

@nguerrera: One more change to match PE/COFF spec, which uses IMAGE_DEBUG_TYPE_REPRO for debug directory entry type.

@nguerrera
Copy link
Contributor

👍

tmat added a commit that referenced this pull request Feb 10, 2016
@tmat
Merge pull request #5995 from tmat/MSA
22948d5 
Move MethodSemanticsAttributes back to System.Reflection namespace
@tmat tmat merged commit 22948d5 into dotnet:master Feb 10, 2016
@karelz karelz modified the milestone: 1.0.0-rtm Dec 3, 2016
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@tmat
Merge pull request dotnet/corefx#5995 from tmat/MSA
10b6b8a 
Move MethodSemanticsAttributes back to System.Reflection namespace

Commit migrated from dotnet/corefx@22948d5
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0-rtm
5 participants
@tmat @nguerrera @karelz @dotnet-bot @dnfclas