This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix handling of ScopeIDs with IPAddresses in NetworkInformation #8462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had the scopeId, we just weren't storing it into the IPAddress.
|
LGTM |
|
Looks good. |
Why complicate the Http tests for this? This should be added maybe to System.Net.Sockets tests using the loopback sockets server. |
Because it's also a way of validating that HttpClient can connect to link-local Uris. I've now made two PRs to fix that behavior for CurlHandler, without tests, and I was already planning to add such a test: |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Fix handling of ScopeIDs with IPAddresses in NetworkInformation Commit migrated from dotnet/corefx@5ff0676
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had the scopeId, we just weren't storing it into the IPAddress.
(As with other aspects of NetworkInformation, this is hard to add a test for, but I'm going to add a test to the HttpClient suite that tries to use a link-local Uri with a loopback server, and that will implicitly provide some verification here, as that will only succeed if the scope ID is correct.)
Fixes https://github.com/dotnet/corefx/issues/8458
cc: @mellinoe, @ericeil, @mikeharder