-
Notifications
You must be signed in to change notification settings - Fork 5k
Conversation
f431442
to
de15101
Compare
{ | ||
if (t.IsFaulted) tcs.SetException(t.Exception.InnerExceptions); | ||
else if (t.IsCanceled) tcs.SetCanceled(); | ||
else if (Interlocked.Decrement(ref remaining) == 0) tcs.SetResult(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Our coding guidelines currently don't permit these single line if/else statements but rather require braces, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll expand it.
de15101
to
6a26710
Compare
LGTM |
Test Innerloop OSX Debug Build and Test please (build machine went offline) |
@mmitche, do our Ubuntu VMs have IPv6 enabled? These tests pass for me locally, but when trying to bind to an IPv6 address, it's failing in the lab:
|
This brings up an interesting issue. In the past, we (networking team) had to deal with IPv4 and/or IPv6 being disabled/un-installed when doing networking things in .NET Framework. The current version of Windows, for example, can probably still disable (not un-install) IPv6 protocol bindings. Sounds like you can do similar in *Nix. So, we should make sure our code is resilient to this and add tests for it. I suggest "unit" tests and not functional tests because then you can easily simulate a machine with only IPv4 and no IPv6 and v.v. |
cc: @CIPop |
How would I find out? |
@dotnet-bot test this please |
Oh, nevermind, it is enabled. The problem is that the fix I made yesterday to ensure that the scope ID is included in an IPAddress isn't yet in the package for System.Net.NetworkInformation being used by this test suite. Once we move to the newer packages, this should be fixed. |
Adds support to the loopback server for binding to IPv6 local addresses, then adds a test that uses both ::1 and a link-local address for the current machine.
6a26710
to
10c8af5
Compare
…test Add HttpClient test with IPv6 Uris Commit migrated from dotnet/corefx@0b51fd2
Adds support to the loopback server for binding to IPv6 local addresses, then adds a test that uses both ::1 and a link-local address for the current machine.
cc: @davidsh, @ericeil, @mellinoe, @mikeharder
(Relies on #8462; won't pass on Unix until that's merged.)