Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Missing values default to a StringDataFrameColumn #2982

Merged
merged 3 commits into from
Oct 20, 2020
Merged

Missing values default to a StringDataFrameColumn #2982

merged 3 commits into from
Oct 20, 2020

Conversation

pgovind
Copy link
Contributor

@pgovind pgovind commented Oct 19, 2020

Fix for #2979

Technically, one could specify the column types in LoadCsv, but I think this behavior of defaulting to a StringDataFrameColumn makes the API behave better.

@pgovind pgovind requested a review from eerhardt October 19, 2020 21:42
@pgovind pgovind mentioned this pull request Oct 19, 2020
Closed
eerhardt
eerhardt approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, once CI is green

@pgovind pgovind merged commit 3bd4a55 into dotnet:master Oct 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eerhardt eerhardt eerhardt approved these changes

Assignees
No one assigned
Labels
area-Microsoft.Data
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pgovind @eerhardt