non shared changes

dotnet · Aug 17, 2018 · c6c8436 · c6c8436
1 parent e1cac05
commit c6c8436
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 60 deletions.
diff --git a/src/System.Private.CoreLib/src/Microsoft/Win32/Registry.cs b/src/System.Private.CoreLib/src/Microsoft/Win32/Registry.cs
diff --git a/src/System.Private.CoreLib/src/Microsoft/Win32/RegistryHive.cs b/src/System.Private.CoreLib/src/Microsoft/Win32/RegistryHive.cs
diff --git a/src/System.Private.CoreLib/src/Microsoft/Win32/RegistryKey.cs b/src/System.Private.CoreLib/src/Microsoft/Win32/RegistryKey.cs
@@ -167,6 +167,11 @@ public void DeleteValue(string name, bool throwOnMissingValue)
             DeleteValueCore(name, throwOnMissingValue);
         }
 
+        public static RegistryKey OpenBaseKey(RegistryHive hKey)
+        {
+            return OpenBaseKey(hKey, RegistryView.Default);
+        }
+
         public static RegistryKey OpenBaseKey(RegistryHive hKey, RegistryView view)
         {
             ValidateKeyView(view);
@@ -552,6 +557,10 @@ internal static RegistryKey GetBaseKey(IntPtr hKey, RegistryView view)
             key._keyName = s_hkeyNames[index];
             return key;
         }
+
+        // This dummy method is added to have the same implemenatation of Registry class. 
+        // Its not being used anywhere. 
+        public void SetValue(string name, object value, RegistryValueKind valueKind) { }
     }
 
     [Flags]

diff --git a/src/System.Private.CoreLib/src/Resources/Strings.resx b/src/System.Private.CoreLib/src/Resources/Strings.resx
@@ -426,6 +426,9 @@
   <data name="Arg_RegKeyNotFound" xml:space="preserve">
     <value>The specified registry key does not exist.</value>
   </data>
+  <data name="Arg_RegInvalidKeyName" xml:space="preserve">
+    <value>Registry key name must start with a valid base key name.</value>
+  </data>
   <data name="Arg_SecurityException" xml:space="preserve">
     <value>Security error.</value>
   </data>

diff --git a/src/System.Private.CoreLib/src/System.Private.CoreLib.csproj b/src/System.Private.CoreLib/src/System.Private.CoreLib.csproj
@@ -347,8 +347,6 @@
     <Compile Include="System\WeakReferenceOfT.cs" />
   </ItemGroup>
   <ItemGroup Condition="'$(TargetsWindows)'=='true' and '$(EnableWinRT)'!='true'">
-    <Compile Include="Microsoft\Win32\Registry.cs" />
-    <Compile Include="Microsoft\Win32\RegistryHive.cs" />
     <Compile Include="Microsoft\Win32\RegistryKey.cs" />
     <Compile Include="Microsoft\Win32\RegistryKey.Windows.cs" />
     <Compile Include="Microsoft\Win32\RegistryOptions.cs" />