This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Get simple tests to work #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -183,3 +183,6 @@ exit /b 1 | |||
|
|
|||
| :AfterILToNativeBuild | |||
|
|
|||
| pushd "%__ProjectDir%\tests" | |||
| call "runtest.cmd" | |||
There was a problem hiding this comment.
Once this goes in, we should make sure that test break will actually result in CI job failing.
|
@gkhanna79 and @janvorli, I've disabled a couple of warnings, could you PTAL? @gkhanna79, I've included your changes as well for Mac. |
| @@ -386,7 +386,7 @@ extern "C" void RhpThrowHwEx() | |||
| #ifndef CPPCODEGEN | |||
| SimpleModuleHeader __module = { NULL, NULL /* &__gcStatics, &__gcStaticsDescs */ }; | |||
|
|
|||
| extern "C" int repro_Program__Main(); | |||
| extern "C" int __managed__Main(); | |||
There was a problem hiding this comment.
Are we also changing this name in the VS solutions since the Wiki references the original function names for setting breakpoints? We should keep the names consistent to ease debugging.
|
LGTM |
Stopgap solution to get simple tests running while proper automation work is in progress Disable Ubuntu/Mac build warning: unused-function.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stopgap solution to get simple tests running while proper automation work is in progress. @jkotas, @MichalStrehovsky PTAL.