Skip to content
This repository has been archived by the owner on Nov 1, 2020. It is now read-only.

Improve name mangling #31

Merged
merged 1 commit into from
Oct 7, 2015
Merged

Improve name mangling #31

merged 1 commit into from
Oct 7, 2015

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Oct 7, 2015

  • Prefix mangled type names by simple name of the containing module.
  • Append instantiation to the mangled names of generic types and methods.
  • Made names generated by the name mangler independent on the compilation order
  • Made name mangler is thread safe by using immutable collections
  • Avoid unnecessary copies while generating the mangled name
  • Fix break in reproNative.vcxproj introduced by my recent commit

The one issue left is that the name mangling is not yet robust against collisions with built-in C++ identifiers or our internal identifiers.

- Prefix mangled type names by simple name of the containing module.
- Append instantiation to the mangled names of generic types and methods.
- Made names generated by the name mangler independent on the compilation order
- Made name mangler is thread safe by using immutable collections
- Avoid unnecessary copies while generating the mangled name
- Fix break in reproNative.vcxproj introduced by my recent commit

The one issue left is that the name mangling is not yet robust against collisions with built-in C++ identifiers or our internal identifiers.
@jkotas jkotas mentioned this pull request Oct 7, 2015
@jkotas
Copy link
Member Author

jkotas commented Oct 7, 2015

@MichalStrehovsky PTLA

cc @davidwrighton

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants