This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Merge nmirror to master #3622
Merged
Merge nmirror to master #3622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eads methods of ThreadPool class. At present worker threads and completion port threads share the same Windows default thread pool, so we cannot properly implement these methods. CR: JKotas, SergeyK [tfs-changeset: 1658202]
Merge changes from TFS
[tfs-changeset: 1658215]
Merge changes from TFS
ENABLE_MIN_WINRT doesn't provide enough support for dynamic interop [tfs-changeset: 1658228]
Merge changes from TFS
Merge master to nmirror
Hopefully, this will fix the other Etw-related test failures I've seen among various projects. ETW propagation to EventListeners was dying internally with a NullReferenceException on EventMetadata.Parameters. EventMetadata.Parameters and EventMetadata.ParameterTypes represent the same data with EventMetadata.Parameters always being null on the toolchain-based path and a comment attached to it saying "Would you hurry up and die already?" The EventSource rules of the code seems to be to check before using Parameters and fallback to using ParameterTypes if necessary but it was forgetting that in a few places.
dotnet-bot
pushed a commit
to dotnet/coreclr
that referenced
this pull request
May 16, 2017
Merge nmirror to master Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas
added a commit
to dotnet/coreclr
that referenced
this pull request
May 16, 2017
Merge nmirror to master Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.