This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Split ILToNative project into compiler .dll and small driver .exe #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MichalStrehovsky PTLA |
| "System.Threading": "4.0.10", | ||
| "System.Text.Encoding.Extensions": "4.0.10", | ||
| "System.Reflection.Extensions": "4.0.0", | ||
| "System.Console": "4.0.0-beta-*", |
There was a problem hiding this comment.
Is System.Console still needed?
There was a problem hiding this comment.
It is not needed - deleted the line.
|
LGTM |
|
Thanks for doing this! |
Minimal change of the interface between the two to make compile again.
This is similar solution to [GenFacade.Desktop](https://github.com/dotnet/buildtools/tree/master/src/GenFacades.Desktop) to annoyances with things like “the façade for System.Console doesn’t ship with the desktop CLR”.
jkotas
added a commit
that referenced
this pull request
Oct 12, 2015
Split ILToNative project into compiler .dll and small driver .exe
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the files around, and fixed things up to make everything compile again. We should plan on making the interface refactored further.
I have also added a convenience desktop project as src\ILNative\desktop (not as src\ILNative.Desktop that we have discussed). It did not look good to have the convenience project in top-level directory. Also, it has a nice side-effect of the desktop convenience project not being in the middle of the real ILToNative projects in the alphabetically sorted VS solution tree.