This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Merge changes from TFS #5549
Merged
Merge changes from TFS #5549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes to UTCNameMangler for 1K/pntestcl 1K tests are special when it comes to symbol linkage. External symbols are resolved by names instead of by ordinals. The change fixes two issues for 1K 1. Do not allow comma in symbol names. For MD arrays, “[md<rank>]” is used instead. 2. Do not prepend a module prefix to symbol names when building pntestcl since the prefix is unknown when building an app against pntestcl. [tfs-changeset: 1691787]
…ch are not cased correctly - This occurs in resource scenarios when a customer mistypes the culture name for their resources as something like "de-de" instead of the actual standard "de-DE" - The fix is to round-trip the name through a CultureInfo which will canonicalize the name to the standard version - The fix is only applied to ecma module reading as NativeFormat metadata is always canonicalized with the CoreRT toolchain [tfs-changeset: 1691837]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging, this PR, please ensure a merge commit is created as automation requires the merge commit. Do not 'Squash and merge' or 'Rebase and merge'!