This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Mirror changes from dotnet/corefx,coreclr #6110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…18952) * Improve throughput of {U}Int32/64.{Try}Parse for hex - Copies/modifies the recently added TryParse32/64IntegerStyle routines for hex in order to provide more optimized parsing. - Since AllowHexSpecifier can't be used with any other styles (other than allowing leading/trailing whitespace), deletes existing code paths for parsing hex. - As I was copying code around, I kept getting bitten by different names used for the same thing, so I also standardized some parameter names in various helper functions. * Clean up - Remove a bunch of unnecessary 'unsafe' keywords - Rephrase some while(true) loops as do/while loops for consistency and to avoid some repetition - Remove an unnecessary wrapper function Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
* Move Decimal to shared
* Remove DecimalCanonicalize{Internal}
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
This fixes shutdown race bug that CoreCLR port reintroduced. Basically the fix needed some Appdomain APIs that were probably not in .NET Core 1.0 so they were removed. However they are back in .NET Core 2.0 so it is trivial to simply 'do the right thing', and put the shutdown logic back. See comment in front of DisposeOnShutdown for more. Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains mirrored changes from dotnet/corefx,coreclr
Please REBASE this PR when merging
cc @stephentoub @vancem @pentp @jkotas @pentp