Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden reflection scanner against invalid IL #7165

Merged
merged 1 commit into from Mar 14, 2019

Conversation

Projects
None yet
2 participants
@MichalStrehovsky
Copy link
Member

MichalStrehovsky commented Mar 14, 2019

Should help with the KnownGood test failures seen in #7157.

The IsValid check in Skip should be all that's needed to fix the observed failures, but I went ahead and hardened it against other invalid situations (end of body in the middle of an instruction, or bad calls).

@MichalStrehovsky

This comment has been minimized.

Copy link
Member Author

MichalStrehovsky commented Mar 14, 2019

@sergiy-k

This comment has been minimized.

Copy link
Contributor

sergiy-k commented Mar 14, 2019

Thank you!

@MichalStrehovsky MichalStrehovsky merged commit fd7eb0e into dotnet:master Mar 14, 2019

3 checks passed

Windows_NT_Wasm Debug and CoreCLR tests WebAssembly Build finished.
Details
Windows_NT_Wasm Release WebAssembly Build finished.
Details
license/cla All CLA requirements met.
Details

@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky:hardenReflectionScan branch Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.