This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Harden reflection scanner against invalid IL #7165
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help with the KnownGood test failures seen in #7157.
The
IsValid
check inSkip
should be all that's needed to fix the observed failures, but I went ahead and hardened it against other invalid situations (end of body in the middle of an instruction, or bad calls).