This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Add Rd.xml documentation #8211
Merged
Add Rd.xml documentation #8211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
reviewed
Jun 21, 2020
loic-sharma
reviewed
Jun 21, 2020
loic-sharma
reviewed
Jun 21, 2020
loic-sharma
reviewed
Jun 21, 2020
Co-authored-by: Lo茂c Sharma <sharma.loic@gmail.com>
Co-authored-by: Lo茂c Sharma <sharma.loic@gmail.com>
Co-authored-by: Lo茂c Sharma <sharma.loic@gmail.com>
|
@loic-sharma my understanding that parameters is just parameters. Can be generic or not. At least this is how I understand the code |
Co-authored-by: Lo茂c Sharma <sharma.loic@gmail.com>
| <Assembly Name="System.Private.CoreLib"> | ||
| <Type Name="System.Collections.Generic.Dictionary`2[[System.Int32,System.Private.CoreLib],[System.String,System.Private.CoreLib]]"> | ||
| <Method Name="EnsureCapacity"> | ||
| <Parameter Name="System.Int32, System.Private.CoreLib" /> |
There was a problem hiding this comment.
Maybe add a comment here that the Parameter is optional and it's only used to disambiguate between overloads if there are any
There was a problem hiding this comment.
Add mention that Parameter is optional.
Co-authored-by: Michal Strehovsk媒 <MichalStrehovsky@users.noreply.github.com>
Co-authored-by: Michal Strehovsk媒 <MichalStrehovsky@users.noreply.github.com>
optional Parameter directive
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documentation provide examples of how rd.xml can be presented.
The only reason for this PR is #8194 (comment)
Hopefully @MichalStrehovsky would keep his word 馃槈