This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Apply CoreRT fixes and workarounds in System.Private.CoreLib #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jkotas
commented
Oct 21, 2015
jkotas
commented
- Intrinsics changed to be compatible with CoreCLR/RyuJIT model
- Temporary ifdefs for not-yet-implemented functionality
|
@tarekgh PTLA |
| @@ -62,6 +58,7 @@ | |||
|
|
|||
| <PropertyGroup> | |||
| <SkipCommonResourcesIncludes>true</SkipCommonResourcesIncludes> | |||
| <DefineConstants>CORERT</DefineConstants> | |||
There was a problem hiding this comment.
We'll need to define this only when we are not building PN as now PN project import the corert project. I can take care of that before enabling the mirroring but it will be nice to put some comment here.
|
other than my comments or questions, it looks good to me. |
|
LGTM. you'll just need to resolve the conflict before you merge it. |
- Intrinsics changed to be compatible with CoreCLR/RyuJIT model - Temporary ifdefs for not-yet-implemented functionality
jkotas
added a commit
that referenced
this pull request
Oct 21, 2015
Apply CoreRT fixes and workarounds in System.Private.CoreLib
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.