Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Parameter and Search Space" notebook #65

Merged
merged 7 commits into from
Sep 23, 2022

Conversation

LittleLittleCloud
Copy link
Contributor

No description provided.

Copy link
Contributor

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good for the most part. I'd add a few things to the intro:

  1. What is a search space?
  2. When should you define your own search space?

I would also move the "Default search space for ML.NET trainer" to the top before the custom definition section.

Copy link
Contributor

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LittleLittleCloud looks good to me. Based on feedback we've received, I would recommend adding links to docs of classes we mention (like SearchSpace).

https://docs.microsoft.com/dotnet/api/microsoft.ml.searchspace.searchspace?view=ml-dotnet-preview

@luisquintanilla luisquintanilla merged commit fc306b1 into dotnet:main Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants