Spec forbidding constant numeric patterns on INumberBase<T>
#6273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to block this for C# 11, so that a future version of C# can call the appropriate APIs on `INumberBase` and make this scenario work as expected.
|
@dotnet/roslyn-compiler @tannergooding for review. |
tannergooding
approved these changes
Jul 13, 2022
jcouv
reviewed
Jul 13, 2022
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Jul 14, 2022
…om or constrained to INumberBase<T> To ensure we have a good user experience and avoid any potential breaking changes later, we block this scenario for types that don't have known conversions from patterns. Spec change: dotnet/csharplang#6273.
|
@jcouv please take another look. |
333fred
added a commit
to dotnet/roslyn
that referenced
this pull request
Jul 25, 2022
…om or constrained to INumberBase<T> (#62653) To ensure we have a good user experience and avoid any potential breaking changes later, we block this scenario for types that don't have known conversions from patterns. Spec change: dotnet/csharplang#6273.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to block this for C# 11, so that a future version of C# can call the appropriate APIs on
INumberBaseand make this scenario work as expected.