Block constant and relational pattern matching on types inheriting from or constrained to INumberBase<T> #62653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om or constrained to INumberBase<T> To ensure we have a good user experience and avoid any potential breaking changes later, we block this scenario for types that don't have known conversions from patterns. Spec change: dotnet/csharplang#6273.
* upstream/main: Bind IterationErrorVariable to a natural type for error recovery (dotnet#62601) [main] Update dependencies from dotnet/source-build-externals (dotnet#61173) Cleanup: remove VisualStudioWorkspaceImpl.TryGetContainedDocument (dotnet#62616) EnC: A couple of small fixes (dotnet#62454) Report error for ref field declared in type other than ref struct (dotnet#62615) Store helpful info needed by incremental-generation on syntax-tree itself (dotnet#62551)
|
|
|
@dotnet/roslyn-compiler bugs fixed, this is now ready for review. |
* upstream/main: (40 commits) Revert "Generalize RoamingProfileStorageLocation to ClientSettingsStorageLocation (dotnet#62684)" Revert "Update SymReader to the latest version (dotnet#62695)" Apply changes directly to text buffer - take 2 (dotnet#62617) Allow diagnostic tagging to use either push or pull diagnostics Tests test and more tests Fix new rename showing overloads when not applicable (dotnet#62559) Add stronger type safety Add support for resolving contextual error types Pass LineFormatting options into OmniSharpCodeAction options Initial approach to supporting contextual types Update dependencies from https://github.com/dotnet/arcade build 20220715.4 (dotnet#62704) Handle diff3 conflict markers (dotnet#62391) Update SymReader to the latest version (dotnet#62695) Generalize RoamingProfileStorageLocation to ClientSettingsStorageLocation (dotnet#62684) Add IWorkspaceProjectContextFactory F# wappers (dotnet#62646) Use OmniSharp LineFormatting fallback options in more places. Remove dependency on Microsoft.VisualStudio.RemoteControl assembly from Features (dotnet#62655) Add array initialization optimization (dotnet#62392) [main] Update dependencies from dotnet/arcade (dotnet#62597) Keep selection on rename invocation (dotnet#62654) ...
|
@dotnet/roslyn-compiler @jcouv for reviews please. |
|
https://github.com/orgs/dotnet/teams/roslyn-compiler @jcouv for reviews please. |
|
@dotnet/roslyn-compiler for a second review please. |
AlekseyTs
reviewed
Jul 20, 2022
AlekseyTs
reviewed
Jul 20, 2022
|
Done with review pass (commit 6) |
AlekseyTs
reviewed
Jul 20, 2022
AlekseyTs
reviewed
Jul 20, 2022
* upstream/main: (66 commits) Merge release/dev17.3 to main (dotnet#62573) Fix Find the right symbol when following type forwards (dotnet#62406) Remove unused parameter (dotnet#62685) Fix NRE in nullable walker (dotnet#62773) Delete obsolete internal options (dotnet#62746) Optimize away unchecked conversions between nint and nuint types. (dotnet#62774) Delete Inline members Clean up global options usage in tests (dotnet#62692) Update dependencies from https://github.com/dotnet/source-build-externals build 20220719.2 (dotnet#62787) Update src/Workspaces/Remote/ServiceHub/Services/Renamer/RemoteRenamerService.cs No need to roundtrip symbol Unused variable formatting Get document properly Lint Simplify Remove unnecessary callbacks Add telemetry ...
AlekseyTs
reviewed
Jul 21, 2022
src/Compilers/CSharp/Test/Semantic/Semantics/PatternMatchingTests5.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Jul 21, 2022
src/Compilers/CSharp/Test/Semantic/Semantics/PatternMatchingTests5.cs
Outdated
Show resolved
Hide resolved
* upstream/main: (53 commits) Remove 'mangleName' parameter in PENamedTypeSymbolNonGeneric (dotnet#62813) Produce errors for 'partial file record' (dotnet#62686) [EnC] Allow renaming methods, properties, events etc. (dotnet#62364) Update AbstractFileHeaderDiagnosticAnalyzer.cs Rename file Make static Move tests Refactor Support ref field assignment in object initializers (dotnet#62584) Fix cref tags on generated VB's SyntaxFactory (dotnet#62578) Simplify Simplify Simplify Simplify Simplify Simplify Simplify Simplify Move helper methods Remove serialization ...
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
This was referenced Jul 25, 2022
ghost
added this to the 
This was referenced Jul 28, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure we have a good user experience and avoid any potential breaking changes later, we block this scenario for types that don't have known conversions from patterns.
Spec change: dotnet/csharplang#6273.