Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed structs link #720

Merged
merged 2 commits into from
Jan 25, 2018
Merged

Fixed structs link #720

merged 2 commits into from
Jan 25, 2018

Conversation

svick
Copy link
Contributor

@svick svick commented Jul 4, 2017

Fixes #660.

This goes back at least to the C# 4.0 spec, which says:

Type declarations (§9.6) are used to define classes (§10), structs (§10.14), interfaces (§13), enums (§14), and delegates (§15).

The relevant part of its TOC looks like this:

  1. Namespaces...................................................................................................................................... 259
    9.6 Type declarations............................................................................................................................. 266
  2. Classes............................................................................................................................................ 269
    10.14 Iterators....................................................................................................................................... 351
  3. Structs............................................................................................................................................. 361
  4. Arrays.............................................................................................................................................. 373
  5. Interfaces........................................................................................................................................ 379
  6. Enums............................................................................................................................................. 399
  7. Delegates........................................................................................................................................ 403

@svick svick mentioned this pull request Jul 4, 2017
Closed
@jcouv jcouv requested a review from gafter November 20, 2017 08:03
@svick
Copy link
Contributor Author

svick commented Nov 20, 2017

I have resolved the merge conflict.

jcouv
jcouv approved these changes Jan 25, 2018
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcouv jcouv merged commit 41f25e8 into dotnet:master Jan 25, 2018
@svick svick deleted the patch-1 branch January 25, 2018 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gafter gafter gafter approved these changes

@jcouv jcouv jcouv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@svick @gafter @jcouv @jongalloway @dnfclas