Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make async overloads of DiagnosticsClient public #3727

Closed
ezsilmar opened this issue Mar 8, 2023 · 3 comments · Fixed by #4394
Closed

Make async overloads of DiagnosticsClient public #3727

ezsilmar opened this issue Mar 8, 2023 · 3 comments · Fixed by #4394
Labels
enhancement New feature or request Microsoft.Diagnostics.NETCore.Client
Milestone
8.0.0

Comments

@ezsilmar
Copy link
Contributor

ezsilmar commented Mar 8, 2023

Hello, I'm facing the issue described in #2151: for some reason EventPipeSession.Start is stuck indefinitely in IPC parsing. This issue was resolved by introducing StartAsync overloads in #2350

However, these overloads are internal. I'd be happy to use them to pass the cancellation token and cleanup the session in this case.
@hoyosjs
Copy link
Member

hoyosjs commented Mar 8, 2023

@tommcdon

@tommcdon tommcdon added this to the 8.0.0 milestone Mar 8, 2023
@tommcdon
Copy link
Member

tommcdon commented Mar 8, 2023

Hello @ezsilmar! Thanks for reporting this issue. Please feel free to submit a PR adding the appropriate public overloads and we will take a look. Otherwise, we will add this item to our team's backlog.

loop-evgeny added a commit to loop-evgeny/dotnet-diagnostics that referenced this issue Nov 13, 2023
@loop-evgeny
Make DiagnosticsClient.StartEventPipeSessionAsync public
89cff6a 
This allows user code to pass a cancellation token without wrapping the call to StartEventPipeSession() in Task.Run() or similar. Resolves dotnet#3727.
@loop-evgeny loop-evgeny mentioned this issue Nov 13, 2023
Merged
@loop-evgeny
Copy link
Contributor

This would be useful for us as well! PR: #4394

davmason pushed a commit that referenced this issue Nov 21, 2023
@loop-evgeny
Make DiagnosticsClient.StartEventPipeSessionAsync public (#4394)
e76bdb8 
This allows user code to pass a cancellation token without wrapping the
call to StartEventPipeSession() in Task.Run() or similar. Resolves
#3727.
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request Microsoft.Diagnostics.NETCore.Client
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Make DiagnosticsClient.StartEventPipeSessionAsync public loop-evgeny/dotnet-diagnostics
4 participants
@ezsilmar @tommcdon @hoyosjs @loop-evgeny