Add new "extended" commands based on ClrMD to dotnet-dump #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikem8361
requested changes
Jul 22, 2020
mikem8361
reviewed
Jul 23, 2020
- TimerInfo lists timers details and displays a summary - both ClrMD 1.1 and 2.0 implementations are provided (based on ClrMD2 symbol defined or not to make the move to 2.0 simple by just removing the 1.1 code)
mikem8361
approved these changes
Jul 24, 2020
|
Is this ready to merge? Or do you want to add the rest of your commands? |
|
Please merge @mikem8361. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defined or not to make the move to 2.0 simple by just removing the 1.1 code)