Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Regression in 2.58.1) docfx.console.targets is no longer in the build folder. Now, it's in the root folder. #7557

Closed
jamiehankins opened this issue Aug 23, 2021 · 2 comments · Fixed by #7560

Comments

@jamiehankins
Copy link
Contributor

jamiehankins commented Aug 23, 2021

Operating System: Windows

DocFX Version Used: 2.58.1

Template used: default

Steps to Reproduce:

  1. Create a C# project with a package reference to DocFX, like this:
<PackageReference
  Include="docfx.console"
  Condition="$(Configuration.Contains('WithDocs'))"
  Version="2.58.1"
  PrivateAssets="all"
  IncludeAssets="runtime; build; native; contentfiles; analyzers; buildtransitive" />
  1. Configure a DocFX build.
  2. Build

Expected Behavior:
docfx.exe is run

Actual Behavior:
docfx.exe is not run

In 2.58.0, and every version before, docfx.console.targets was in the build folder of the NuGet package directory, e.g.
.nuget\packages\docfx.console\2.58.0\build\docfx.console.targets.

Starting with 2.58.1, it is now in the root directory for the package, e.g.
.nuget\packages\docfx.console\2.58.0\docfx.console.targets.

As a result, the targets in docfx.console.targets do not get run.

@yufeih
Copy link
Contributor

yufeih commented Aug 24, 2021

This is likely caused by NuGet/Home#11125, we are pinning the NuGet version now.

@jamiehankins
Copy link
Contributor Author

jamiehankins commented Aug 24, 2021

@yufeih still not fixed.

 Directory of c:\Users\jamie.hankins\.nuget\packages\docfx.console\2.58.2

08/24/2021  11:41    <DIR>          .
08/24/2021  11:41    <DIR>          ..
08/24/2021  11:41               182 .nupkg.metadata
08/23/2021  18:34            18,703 .signature.p7s
08/24/2021  11:41    <DIR>          api
08/24/2021  11:41    <DIR>          articles
08/24/2021  11:41        22,413,701 docfx.console.2.58.2.nupkg
08/24/2021  11:41                88 docfx.console.2.58.2.nupkg.sha512
08/24/2021  01:29               896 docfx.console.nuspec
08/24/2021  01:13             4,692 docfx.console.targets
08/24/2021  01:13             1,091 docfx.json
08/24/2021  01:13               225 index.md
08/24/2021  01:13               110 toc.yml
08/24/2021  11:41    <DIR>          tools
               9 File(s)     22,439,688 bytes
               5 Dir(s)  627,763,617,792 bytes free

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants