Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docfx.console nuget package #7569

Closed
wants to merge 1 commit into from
Closed

fix docfx.console nuget package #7569

wants to merge 1 commit into from

Conversation

tibel
Copy link
Contributor

@tibel tibel commented Aug 25, 2021

fixes #7557

Copy link
Contributor

@jamiehankins jamiehankins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing that when target was removed in #694, DocFX started relying on NuGet to keep the directory name if target is empty. NuGet 5.10.0 seems to have changed that behavior.

This seems like a better fix that pinning to an old version of NuGet.

@yufeih
Copy link
Contributor

yufeih commented Aug 26, 2021

@jamiehankins @tibel , I'm preferring #7571 over this PR because this syntax <file src="build/**" target="build"/> can have different interpretations:

  1. If src is treated as a transparent glob pattern, then the glob matcher for build/a.txt yields build/a.txt and place it at build/build/a.txt like the behavior in 5.9.1
  2. If NuGet tries to remove common prefix using the target attribute, then the glob matcher for build/a.txt yields build/a.txt and then turn it into a.txt before placing it to build/a.txt, like the behavior in 5.10.0
  3. If NuGet tries to be really clever and look for ** in the glob pattern, then the glob matcher for build/a.txt yields a.txt place it at build/a.txt, like the behavior in 5.10.0. (But what does it mean for glob patterns like build/**/a** or buil?/**?)

I'd like to wait for the NuGet team to clarify the behavior on NuGet/Home#11125, maybe it is a regression, maybe they intentionally adjust the behavior for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Regression in 2.58.1) docfx.console.targets is no longer in the build folder. Now, it's in the root folder.
3 participants