Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Regression) NuGet Layout Still Broken #7570

Closed
jamiehankins opened this issue Aug 25, 2021 · 4 comments
Closed

(Regression) NuGet Layout Still Broken #7570

jamiehankins opened this issue Aug 25, 2021 · 4 comments
Assignees
@v-pegao

Comments

@jamiehankins
Copy link
Contributor

Operating System: Windows

DocFX Version Used: 2.58.2

Template used: default

Steps to Reproduce:

  1. Create a C# project with a package reference to DocFX, like this:
<PackageReference
  Include="docfx.console"
  Version="2.58.2"
  PrivateAssets="all"
  IncludeAssets="runtime; build; native; contentfiles; analyzers; buildtransitive" />
  1. Configure a DocFX build.
  2. Build

Expected Behavior:
docfx.exe is run

Actual Behavior:
docfx.exe is not run

This was originally filed as #7557.

The PR to fix it, #7560, pinned version 5.10 of NuGet. Unfortunately, according to NuGet/Home#11125, the regression in NuGet was introduced in 5.10. The version that should be pinned is 5.9.1.
jamiehankins added a commit to jamiehankins/docfx that referenced this issue Aug 25, 2021
@jamiehankins
Pin NuGet to 5.9.1
e1df4c1 
This is to fix issue dotnet#7570. The original PR, dotnet#7560, pinned NuGet to
version 5.10. However, the regression was introduced by 5.10. This
PR pins NuGet to 5.9.1.
@jamiehankins jamiehankins mentioned this issue Aug 25, 2021
Merged
yufeih pushed a commit that referenced this issue Aug 26, 2021
@jamiehankins
Pin NuGet to 5.9.1 (#7571)
a326129 
This is to fix issue #7570. The original PR, #7560, pinned NuGet to
version 5.10. However, the regression was introduced by 5.10. This
PR pins NuGet to 5.9.1.
@jamiehankins
Copy link
Contributor Author

Hi @yufeih any chance of 2.58.3 for this? We've been waiting for the the older fixes (#7422) for a long time, and this (hopefully) is the last thing blocking us.

@yufeih yufeih added the P0 label Sep 6, 2021
@tibel
Copy link
Contributor

tibel commented Sep 8, 2021 •
edited
Loading

issue is not fixed in 2.58.3

@v-pegao v-pegao mentioned this issue Sep 9, 2021
Merged
@jamiehankins
Copy link
Contributor Author

Confirmed that it's not fixed in 2.58.3.

The fix above by @v-pegao looks promising. Hopefully, 2.58.4 will be the end of this issue.

@yufeih
Copy link
Contributor

yufeih commented Sep 14, 2021

Fixed in 2.58.4

@yufeih yufeih closed this as completed Sep 14, 2021
@yufeih yufeih mentioned this issue Sep 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@v-pegao v-pegao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tibel @yufeih @jamiehankins @v-pegao