Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New PDF Engine does not seem to work #9393

Closed
groogiam opened this issue Nov 7, 2023 · 2 comments
Closed

New PDF Engine does not seem to work #9393

groogiam opened this issue Nov 7, 2023 · 2 comments
Labels
bug A bug to fix

Comments

@groogiam
Copy link

groogiam commented Nov 7, 2023

Describe the bug
I am attempting to follow the documentation for the new PDF engine here gttps://dotnet.github.io/docfx/docs/pdf.html. The documentation references a "Download PDF" but after following the instructions and updating my docfx.json file one does not appear after rebuilding.

To Reproduce
Steps to reproduce the behavior:

Added to my docfx.json

{
  "build": {
    "globalMetadata": {
      "pdf": true
    }
  }
}

Then ran

docfx build docfx.json -s

The site builds with no errors and I can open it in my browser but there is no Download PDF button.

Expected behavior
The "Download PDF" button should show as per the documentation.

Context (please complete the following information):

  • OS: Windows 10 Pro
  • Docfx version: 2.73.1+1d7b96c23465e14eafbcb0dd765029a87b5312d4

Additional context
Add any other context about the problem here.

@groogiam groogiam added the bug A bug to fix label Nov 7, 2023
@groogiam
Copy link
Author

groogiam commented Nov 7, 2023

After some playing around it does seem to be generating multiple pdf files in the background but still no links. I still have several other issues.

  1. Is there a way to generate a single pdf document with all the content instead of a bunch of one off pdf's. The old engine had this support but it appears this was not accounted for in the new engine.
  2. pdfCoverPage metadata does not seem to work. The documentation is a bit unclear. The old engine referenced a markdown file in the repository. This seems to reference something from the output but the any pdf title page I generate is not part of the output and I would not want it to show up there.
  3. pdfTocPage seems to be adding numbers at the end of the text.

image

Thanks in advance for your help.

@yufeih
Copy link
Contributor

yufeih commented Nov 8, 2023

The "Download PDF link" and TOC page styling is currently only applied to the modern template. Is it feasible to use that template instead?

yufeih added a commit that referenced this issue Nov 8, 2023
@dotnet dotnet locked and limited conversation to collaborators Nov 8, 2023
@yufeih yufeih converted this issue into discussion #9400 Nov 8, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
bug A bug to fix
Projects
None yet
Development

No branches or pull requests

2 participants