clean up code of netcore sdk support #4827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4708 removed
Microsoft.Buildpackage reference. This is the right way to useMSBuildLocator, and we are no longer coupled with Visual Studio new release, but users with .NET Core SDK alone installed will no longer work.microsoft/MSBuildLocator#21 exposes a new method for user to provide msbuild location for this issue. To use this, users usually need to install "Build Tools for Visual Studio" to prepare this, but it finally makes MSBuildLocator think Visual Studio is installed. This makes the NO-VS user fallback take no effect.
As a result, we can stop supporting users with .NET Core SDK alone to work. The minimal requirement is "Build Tools for Visual Studio".
Microsoft Reviewers: Open in CodeFlow