Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Quickenshtein to get levenshtein distance #6774

Merged
merged 1 commit into from Nov 19, 2020
Merged

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Nov 14, 2020

Lots of interesting performance tunings put into the library:

https://www.youtube.com/watch?v=JiOYajl2Mds

Microsoft Reviewers: Open in CodeFlow

@yufeih yufeih added the v3 label Nov 14, 2020
@mingwli
Copy link
Contributor

mingwli commented Nov 16, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@VSC-Service-Account
Copy link

docs(00:00:37.1213457, 0 more diff)
diff --git "a/D:/docfx.TestData\\regression-test.docs\\output/.publish.json" "b/D:/docfx.TestData\\regression-test.docs\\.temp/.publish.json"
index fc3c0bc..13fa7c3 100644
--- "a/D:/docfx.TestData\\regression-test.docs\\output/.publish.json"
+++ "b/D:/docfx.TestData\\regression-test.docs\\.temp/.publish.json"
@@ -81745,7 +81745,6 @@
         "NextTurn",
         "nemrism",
         "anonymousgituser",
-        "NetMage",
         "mjhoffman65",
         "brgirgis",
         "mikeblome",
diff --git "a/D:/docfx.TestData\\regression-test.docs\\output/dotnet/csharp/language-reference/keywords/ref.mta.json" "b/D:/docfx.TestData\\regression-test.docs\\.temp/dotnet/csharp/language-reference/keywords/ref.mta.json"
index f8a00bb..2448d6c 100644
--- "a/D:/docfx.TestData\\regression-test.docs\\output/dotnet/csharp/language-reference/keywords/ref.mta.json"
+++ "b/D:/docfx.TestData\\regression-test.docs\\.temp/dotnet/csharp/language-reference/keywords/ref.mta.json"
@@ -29,7 +29,6 @@
     "NextTurn",
     "nemrism",
     "anonymousgituser",
-    "NetMage",
     "mjhoffman65",
     "brgirgis",
     "mikeblome",
diff --git "a/D:/docfx.TestData\\regression-test.docs\\output/dotnet/csharp/language-reference/keywords/ref.raw.page.json" "b/D:/docfx.TestData\\regression-test.docs\\.temp/dotnet/csharp/language-reference/keywords/ref.raw.page.json"
index 67b4dcb..6f0db5f 100644
--- "a/D:/docfx.TestData\\regression-test.docs\\output/dotnet/csharp/language-reference/keywords/ref.raw.page.json"
+++ "b/D:/docfx.TestData\\regression-test.docs\\.temp/dotnet/csharp/language-reference/keywords/ref.raw.page.json"
@@ -270,12 +270,6 @@ bc.ListBooks();⬇
           "display_name": "anonymousgituser",
           "id": "31715568"
         },
-        {
-          "name": "NetMage",
-          "profile_url": "https://github.com/NetMage",
-          "display_name": "NetMage",
-          "id": "171247"
-        },
         {
           "name": "mjhoffman65",
           "profile_url": "https://github.com/mjhoffman65",
@@ -341,7 +335,6 @@ bc.ListBooks();⬇
       "NextTurn",
       "nemrism",
       "anonymousgituser",
-      "NetMage",
       "mjhoffman65",
       "brgirgis",
       "mikeblome",

@ghost
Copy link

ghost commented Nov 16, 2020

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@VSC-Service-Account
Copy link

🧭VBA-Docs(00:01:02.7921132 | exceed 60s)

@yufeih yufeih merged commit 8cae64e into dotnet:v3 Nov 19, 2020
@yufeih yufeih deleted the quickenshtein branch November 19, 2020 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants